Rename services to actions #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelgrom
reviewed
Aug 1, 2024
...io/homeassistant/companion/android/common/data/integration/impl/IntegrationRepositoryImpl.kt
Show resolved
Hide resolved
jpelgrom
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renames services to actions as thats happening in the next HA release. I don't think we should worry about changing the UI based on the version of HA core as even HA documentation is being updated now.
Initially I started off only changing the strings but then I changed the string names for uniformity and that led to updating the rest of the code as I felt it would help with code readability. I did make an attempt at updating the button widget database to reflect the new name but the automigration was not playing nice so I left it alone as its only referenced in a handful of places.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes