Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ccl from custom to core integrations #6221

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

fkiscd
Copy link
Contributor

@fkiscd fkiscd commented Dec 14, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@fkiscd fkiscd marked this pull request as ready for review December 14, 2024 22:24
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Dec 15, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @fkiscd 👋

The PR explains this is moving assets from custom to core. However, the contents of the PR only add new content and thus isn't a move of files.

Could you take a look?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 15, 2024 10:51
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@fkiscd
Copy link
Contributor Author

fkiscd commented Dec 27, 2024

Hmm, it's so weird that the commit messages do show that they're moves of files. Anyway thank you for pointing that out.

@fkiscd fkiscd marked this pull request as ready for review December 27, 2024 03:38
@home-assistant home-assistant bot requested a review from frenck December 27, 2024 03:38
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants