Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harvey branding #6272

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

Jordi1990
Copy link
Contributor

Proposed change

Adds branding for Harvey softeners for virtual integration.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the icons look squashed, is that how the manufacturer uses their branding as well?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 23, 2024 20:57
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Jordi1990
Copy link
Contributor Author

Hmm the icons look squashed, is that how the manufacturer uses their branding as well?

../Frenck

You're right it doesn't look right, I've checked this and also noticed they have updated their branding since I made this branch. They supply a square logo now so I updated the icon images and remove the logo so that it will fall back to the icon image.

@Jordi1990 Jordi1990 marked this pull request as ready for review December 23, 2024 23:21
@home-assistant home-assistant bot requested a review from frenck December 23, 2024 23:21
@joostlek joostlek added the parent-merged The parent PR has been merged already label Dec 24, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Jordi1990 👍

../Frenck

@frenck frenck added the has-parent This PR has a parent PR in a other repo label Dec 24, 2024
@frenck frenck merged commit 041b3c1 into home-assistant:master Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants