-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add harvey branding #6272
Add harvey branding #6272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm the icons look squashed, is that how the manufacturer uses their branding as well?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
You're right it doesn't look right, I've checked this and also noticed they have updated their branding since I made this branch. They supply a square logo now so I updated the icon images and remove the logo so that it will fall back to the icon image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Jordi1990 👍
../Frenck
Proposed change
Adds branding for Harvey softeners for virtual integration.
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)