Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding for smsto integration #6285

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cnecrea
Copy link

@cnecrea cnecrea commented Dec 25, 2024

Proposed change

Added logo.png and icon.png files for the smsto integration.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/cnecrea/smsto

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Added logo.png and icon.png files for the smsto integration.
Add branding for smsto integration
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @cnecrea 👋

The provided branding doesn't seem to match the branding used by sms.to.

CleanShot 2025-01-02 at 12 38 44

Could you make sure the branding matches?

Also, the logo version seems to have a transparency issue.

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 2, 2025 11:39
@home-assistant
Copy link

home-assistant bot commented Jan 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants