Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for Energetyczny Kompas custom integration #6316

Closed
wants to merge 1 commit into from

Conversation

kkubicki
Copy link

@kkubicki kkubicki commented Jan 1, 2025

Proposed change

Integration for Energetyczny Kompas platform.
https://github.com/kkubicki/ha-energetyczny-kompas-calendar

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @kkubicki 👋

It seems like the icons provided are application icons and not branding of the service provider. The linked page shows this as their branding:

CleanShot 2025-01-02 at 10 35 23

Which is the branding we would have expected to be used in this PR as well.

Could you take a look?

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 2, 2025 09:36
@home-assistant
Copy link

home-assistant bot commented Jan 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@kkubicki
Copy link
Author

kkubicki commented Jan 2, 2025

Hello, yes you're right - I should be more specific. PSE is electricity network operator, but different Logo/Icon is matching their application which provides electricity demand (that's what the custom component is specifically for):
obraz
obraz

@frenck
Copy link
Member

frenck commented Jan 2, 2025

Right, but we are not collecting app icons in this repository.

../Frenck

@kkubicki
Copy link
Author

kkubicki commented Jan 2, 2025

I see, in that case I guess I have to use PSE logo from another component? It is already in this repository.

@kkubicki kkubicki closed this Jan 10, 2025
@kkubicki kkubicki mentioned this pull request Jan 10, 2025
12 tasks
@KrzysiekLegnica
Copy link

icon
logo
OK, new files attached

@kkubicki
Copy link
Author

kkubicki commented Jan 10, 2025

Hi @KrzysiekLegnica, I am author of this pull request:
1/ This pull request is already closed - you need to update your pull request
2/ Picture files should be added in commit, not in comments (see README of this repo or take my commit as an example 456bc33)
3/ Your logos doesn't match PSE logo - what is source of your pictures?
4/ PSE logos are already in this repository under other domain names (see #5587 and #3350), I think you could re-use them by changing domain name of your integration accordingly. EDIT: domain re-use is prohibited, it has to be unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants