Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xiaomi Protocol #6552

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

vaughan-zeng
Copy link
Contributor

@vaughan-zeng vaughan-zeng commented Feb 13, 2025

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @vaughan-zeng 👋

This pull request contains brand assets for two different integrations. However, each pull request should only contain a single integration at the time.

Please split this pull request into two separate pull requests.

Thanks! 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 14, 2025 09:39
@vaughan-zeng
Copy link
Contributor Author

vaughan-zeng commented Feb 14, 2025

Oh hi there @vaughan-zeng 👋

This pull request contains brand assets for two different integrations. However, each pull request should only contain a single integration at the time.

Please split this pull request into two separate pull requests.

Thanks! 👍

../Frenck

@frenck

Thank you for the feedback! I've removed the brand assets for Integration B and kept only the files for Integration A in this PR, as requested.

This pull request now exclusively contains the brand assets for:

Integration Name: xiaomi_protocol

Please review the updated changes at your convenience. Let me know if any additional adjustments are needed.

Thanks for your guidance! 🙌

@vaughan-zeng vaughan-zeng marked this pull request as ready for review February 14, 2025 13:18
@home-assistant home-assistant bot requested a review from frenck February 14, 2025 13:18
@frenck frenck changed the title Add a new logo or icon for a new core integration Add Xiaomi Protocol Feb 15, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vaughan-zeng 👍

However, I wasn't able to find the public repository that provides this custom integration. Could you please point me to it?

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 15, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants