-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xiaomi Protocol #6552
base: master
Are you sure you want to change the base?
Add Xiaomi Protocol #6552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hi there @vaughan-zeng 👋
This pull request contains brand assets for two different integrations. However, each pull request should only contain a single integration at the time.
Please split this pull request into two separate pull requests.
Thanks! 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thank you for the feedback! I've removed the brand assets for Integration B and kept only the files for Integration A in this PR, as requested. This pull request now exclusively contains the brand assets for: Integration Name: xiaomi_protocol Please review the updated changes at your convenience. Let me know if any additional adjustments are needed. Thanks for your guidance! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @vaughan-zeng 👍
However, I wasn't able to find the public repository that provides this custom integration. Could you please point me to it?
Thanks 👍
../Frenck
Proposed change
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)