New Network API #259
Merged
New Network API #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pvizeli
commented
Nov 10, 2020
•
pvizeli
commented
- wifi scan
- new update
- create vlan
frenck
previously approved these changes
Nov 11, 2020
Co-authored-by: Franck Nijhof <git@frenck.dev>
frenck
approved these changes
Nov 11, 2020
agners
reviewed
Nov 11, 2020
|
|
||
| networkUpdateCmd.Flags().StringArray("ip6-address", []string{}, "IPv6 address for the interface in the 2001:0db8:85a3:0000:0000:8a2e:0370:7334/64") | ||
| networkUpdateCmd.Flags().String("ipv6-gateway", "", "The IPv6 gateway the interface should use") | ||
| networkUpdateCmd.Flags().String("ipv6-method", "", "Method on IPv6: static|dhcp|disabled") |
There was a problem hiding this comment.
In IPv6 you have SLAAC (Stateless Address Auto-configuration) and DHCPv6. Lot of people do not have DHCP with IPv6. It seems that Network Manager uses the method auto to support the two of them, I think using auto instead of dhcp is more appropriate here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.