Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mealie import recipe uses incorrect url #132424

Closed
keliam opened this issue Dec 5, 2024 · 3 comments · Fixed by #134274
Closed

Mealie import recipe uses incorrect url #132424

keliam opened this issue Dec 5, 2024 · 3 comments · Fixed by #134274
Assignees

Comments

@keliam
Copy link

keliam commented Dec 5, 2024

The problem

When trying to use the mealie.import_recipe action, a 405 error is returned.

What version of Home Assistant Core has the issue?

2024.12.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Mealie

Link to integration documentation on our website

https://www.home-assistant.io/integrations/mealie

Diagnostics information

No response

Example YAML snippet

data:
  url: https://joyfoodsunshine.com/the-most-amazing-chocolate-chip-cookies/
  config_entry_id: 01JEC2SFRJ5Y9DK3Y827HMEJH2
  include_tags: true
action: mealie.import_recipe

Anything in the logs that might be useful for us?

INFO     2024-12-05T15:02:15 - [172.30.32.1:0] 405 Method Not Allowed "POST /api/recipes/create-url HTTP/1.1"

Additional information

Per the Mealie docs, it appears the endpoint should be "/api/recipes/create/url" rather than what the integration is sending (/api/recipes/create-url).
The request works correctly when testing via http://your-mealie-site/docs per https://docs.mealie.io/documentation/getting-started/api-usage/

@home-assistant
Copy link

home-assistant bot commented Dec 5, 2024

Hey there @joostlek, @andrew-codechimp, mind taking a look at this issue as it has been labeled with an integration (mealie) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mealie can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign mealie Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


mealie documentation
mealie source
(message by IssueLinks)

@andrew-codechimp
Copy link
Contributor

This was a breaking change with Mealie v2, https://docs.mealie.io/contributors/developers-guide/migration-guide/

Could potentially handle in lib with a property for version, which gets via /about call if not already and then make a conditional call depending on version. Nightly version would have to assume v2.

@andrew-codechimp
Copy link
Contributor

@homeassistant add-label problem in dependency

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants