Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create recipe fix #381

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Conversation

andrew-codechimp
Copy link
Contributor

Proposed Changes

Add a version property to be able to determine correct URL, which changed in V2

Related Issues

home-assistant/core#132424

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.34%. Comparing base (472d605) to head (aaea3be).

Files with missing lines Patch % Lines
src/aiomealie/mealie.py 53.84% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   99.08%   97.34%   -1.74%     
==========================================
  Files           4        4              
  Lines         327      339      +12     
  Branches       15       17       +2     
==========================================
+ Hits          324      330       +6     
- Misses          2        7       +5     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joostlek
Copy link
Owner

Did you just read the exact same thread I did or is this just pure coincidence?

@joostlek joostlek added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Dec 30, 2024
@joostlek joostlek merged commit f3a7029 into joostlek:main Dec 30, 2024
11 of 12 checks passed
@andrew-codechimp
Copy link
Contributor Author

This has been floating around for a while so I just had a go!

@andrew-codechimp andrew-codechimp deleted the create-recipe-fix branch December 30, 2024 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants