-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xiaomi vacuum V2 fan speed is not mapped correctly #17695
Comments
See my comment in #17090 - this needs to be fixed in the upstream library (PRs welcome!). |
It is not a problem - only that Mop is missing. |
But it is not an issue for the underlying library because it doesn't know about the speeds and it doesn't enumerate them, it just set them by integer value. HA is enumerating the speeds and using library to set them to certain integer value. That would be brand new feature for underlying library to know which type of vacuum it is communicating with and the PR would also need to change the API because now the underyling library would be doing the enumeration of speeds. And then we would also need to change HA. |
I agree with @drndos, this feature might take a very long time to be implemented in the underlying library. As a faster fix, we could add a flag in the component yaml config, telling it which mapping it should use (old or new) |
@poma
|
For myself I've just made an override .py file with the correct mapping, only had to change a few numbers. I'll make a PR because I want it to work for other users out of the box. |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. |
mapping is still wrong. |
Just for the record, @bugficks created a PR to fix this issue in the backend library (rytilahti/python-miio#523), but closed it afterwards out of no interest. |
@rytilahti Maybe do a shot at moving it forward nevertheless? |
well if there is no response to a pull request after a week that shows me there is no interest, hence I have closed the pull request. simple as that. |
@bugficks A week? I'm sorry sir, but that is not uncommon in the open source world. Furthermore, I personally don't see why one should close PR because of "waiting" too long. But that is personal I guess :) |
@frenck if you say so :) I'm used to some sort of reply within a few days. My fork is still available for now and if someone had asked to reopen PR I would have done so. |
Sorry for not being responsive enough, I've seen the PR and it looks good from the surface, but I haven't unfortunately have had enough time to dig into the specifics nor do I have currently access to test it myself. As I cannot test it myself, I'm really hesitant on simply merging it and pushing out a new release (in case it then breaks down on someone's setup). So if anyone is willing to do some testing (verifying that everything works just fine also with the v1 vacuum), I think we can go ahead, merge that PR and I can prepare a new release so we can finally get that fixed. If there are no volunteers I will be doing that by myself when I'll get access to a device later this year (some point in October). As I hope it doesn't have to wait that long, I hope that some other people will do testing on it and report on that PR :-) |
Hi! I just start the jurney with HA and I really want help with the MOP functions. I create special area to clean with mop and now I need to change normal mode to mop :D How can I help You with that? |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. |
Home Assistant release with the issue:
0.80.3
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):
Hass on raspberry pi 3b+
Component/platform:
Xiaomi Mi Robot Vacuum
https://www.home-assistant.io/components/vacuum.xiaomi_miio/
Description of problem:
Fan speed are not mapped correctly for the Xiaomi vacuum V2 Correct values are:
Quiet: 101
Balanced: 102
Turbo: 103
Max: 104
Mop: 105
Problem-relevant
configuration.yaml
entries and (fill out even if it seems unimportant):Traceback (if applicable):
Additional information:
The text was updated successfully, but these errors were encountered: