Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xiaomi_miio.py #17090

Closed
wants to merge 1 commit into from
Closed

Conversation

zanerv
Copy link

@zanerv zanerv commented Oct 3, 2018

Description:

Update fanspeeds to reflect values that Mi Home app is sending to the vacuum
Tested on Roborock S50, I've set the fanspeed in the app and checked the value with mirobo

Quiet
Fanspeed: 101 %

Balanced
Fanspeed: 102 %

Turbo
Fanspeed: 103 %

MAX
Fanspeed: 104 %

Mop
Fanspeed: 105 %

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@zanerv zanerv requested review from rytilahti and syssi as code owners October 3, 2018 11:47
@homeassistant
Copy link
Contributor

Hi @zanerv,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values are only valid to the 2nd generation model, the proper way to fix this is to change python-miio to report back the available fan speeds per model and use that information inside home-assistant.

@zanerv
Copy link
Author

zanerv commented Oct 3, 2018

yep, that makes sense.

@zanerv zanerv closed this Oct 3, 2018
@ghost ghost removed the in progress label Oct 3, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants