Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aiohttp to 3.9.0b0 #101627

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Update aiohttp to 3.9.0b0 #101627

merged 2 commits into from
Oct 8, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 7, 2023

Proposed change

https://github.com/aio-libs/aiohttp/releases/tag/v3.9.0b0
https://github.com/aio-libs/aiohttp/blob/v3.9.0b0/CHANGES.rst#390b0-2023-10-07

This might be a bit unusual. How about we upgrade to the beta version for aiohttp and see how it goes?

Version 3.9.0 will be required for Python 3.12, so this would allow us to start testing it (unofficially). Furthermore, if there are any issues with b0, we'll have almost three weeks of testing to find out. Since it's almost fully compatible with 3.8, we could just revert this PR either completely or just for the next release if it doesn't work out / we find something unexpected.

There are some (optional) changes to improve the typing of the app data. I'd propose to wait with those until after we've moved to the final 3.9.0 release. https://docs.aiohttp.org/en/latest/web_advanced.html#application-s-config

Wheels are already up on: https://wheels.home-assistant.io/musllinux/

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 7, 2023

Hey there @davet2001, mind taking a look at this pull request as it has been labeled with an integration (generic) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of generic can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign generic Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Oct 7, 2023

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@cdce8p cdce8p requested review from frenck and bdraco October 7, 2023 23:28
@bdraco
Copy link
Member

bdraco commented Oct 7, 2023

Upgrading to a beta release is a bit unusual, but there is a lot of special cases for aiohttp already, and as you point out we can revert it before the next release if needed. I think its better to at least get some testing and discover the problems sooner rather than later so it seems fine as long as we revert this PR before the end of HA beta if 3.9.0 isn't officially released by than.

@bdraco
Copy link
Member

bdraco commented Oct 7, 2023

I'm going to push this to my production and report back

@bdraco
Copy link
Member

bdraco commented Oct 8, 2023

So far so good on two production systems.

Going to push wider

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working just fine

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's do it and re-evaluate before beta.

../Frenck

@frenck frenck merged commit 3155e62 into dev Oct 8, 2023
45 checks passed
@frenck frenck deleted the update-aiohttp branch October 8, 2023 11:21
Comment on lines +61 to +62
# Overwrite base aiohttp _wait implementation
# Homeassistant has a custom shutdown wait logic.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdce8p Would a cleaner approach work by just setting shutdown_timeout to 0?

If not, then maybe there are some improvements to be made in aiohttp...

I'd also be curious how homeassistant's shutdown logic works.

@cdce8p cdce8p mentioned this pull request Oct 9, 2023
32 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants