Add icon translations support #103294
Merged
Add icon translations support #103294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
dependency-bump
new-feature
small-pr
edenhaus
reviewed
Nov 6, 2023
edenhaus
reviewed
Nov 7, 2023
frenck
force-pushed
the
frenck-2023-1366
branch
2 times, most recently
from
a73b682 to
7997430
Compare
frenck
force-pushed
the
frenck-2023-1366
branch
from
7997430 to
31b8815
Compare
Yes, while moving this to icon translations, I removed those (as those are the default already). ../Frenck |
frenck
force-pushed
the
frenck-2023-1366
branch
from
484a99c to
f7e0300
Compare
edenhaus
reviewed
Dec 13, 2023
frenck
force-pushed
the
frenck-2023-1366
branch
from
aac3b8f to
2cf47cd
Compare
edenhaus
approved these changes
Jan 5, 2024
9 tasks
piitaya
reviewed
Jan 15, 2024
frenck
force-pushed
the
frenck-2023-1366
branch
from
a2f02f6 to
7a9f6ec
Compare
5 tasks
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
frenck
force-pushed
the
frenck-2023-1366
branch
from
7a9f6ec to
70cd1bd
Compare
3 tasks
Comment on lines
+65
to
+66
| if files_to_load and ( | ||
| load_icons_job := hass.async_add_executor_job(_load_icons_files, files_to_load) |
There was a problem hiding this comment.
load_icons_job will never be falsy, as it will always return a Future. I think we can remove the second condition.
|
|
||
| integrations: dict[str, Integration] = {} | ||
| domains = list({loaded.rpartition(".")[-1] for loaded in components}) | ||
| ints_or_excs = await async_get_integrations(self._hass, domains) |
There was a problem hiding this comment.
I think we should write out the words in the variable name. ints sounds like integers to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add support for icon translations, as described in:
home-assistant/architecture#980
Frontend support: home-assistant/frontend#19406
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: