Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.9.0rc0 for python 3.12 only #103507

Merged
merged 12 commits into from
Nov 15, 2023
Merged

Bump aiohttp to 3.9.0rc0 for python 3.12 only #103507

merged 12 commits into from
Nov 15, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 6, 2023

Proposed change

changelog: aio-libs/aiohttp@v3.9.0b0...v3.9.0rc0

This should fix all the known issues we had with b0

The plan is to get a full release soon which should unblock python 3.12 support in production 🤞 once we also bump aiohttp in supervisor

Note: the 502s from ingress will return until supervisor until home-assistant/supervisor#4710 is merged, or aiohttp is upgraded to 3.9.0+ in supervisor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

changelog: aio-libs/aiohttp@v3.9.0b0...v3.9.0b1

This should fix all the known issues we had with b0
@bdraco bdraco requested a review from a team as a code owner November 6, 2023 13:52
@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Nov 6, 2023
@joostlek
Copy link
Member

joostlek commented Nov 6, 2023

bieniu/accuweather#267

@cdce8p
Copy link
Member

cdce8p commented Nov 6, 2023

zxdavb/evohome-async#11

@cdce8p
Copy link
Member

cdce8p commented Nov 6, 2023

@joostlek If you're interested, it looks like theses are effected as well:

@joostlek
Copy link
Member

joostlek commented Nov 6, 2023

bieniu/nettigo-air-monitor#273
bieniu/gios#254

@cdce8p
Copy link
Member

cdce8p commented Nov 6, 2023

/CC @bieniu In case you haven't seen the PRs on your repos 😄

@bieniu
Copy link
Member

bieniu commented Nov 6, 2023

I saw the notifications, sorry for that mess 😁 Within 2 hours I will be home and I will merge PRs and release new versions of packages.

@bdraco bdraco marked this pull request as ready for review November 7, 2023 01:48
@bdraco
Copy link
Member Author

bdraco commented Nov 7, 2023

@Kane610 would you mind taking a look at the failing test here. I'm not sure if the test has a race of if it's a regression in aiohttp

Nevermind, sorry for the ping, I found a solution that keeps test compat

@bdraco bdraco marked this pull request as draft November 7, 2023 14:31
@bdraco
Copy link
Member Author

bdraco commented Nov 7, 2023

We are going to need a b2 to move testing forward as aio-libs/aiohttp#7798 is a blocker

@Kane610
Copy link
Member

Kane610 commented Nov 7, 2023

@Kane610 would you mind taking a look at the failing test here. I'm not sure if the test has a race of if it's a regression in aiohttp

Nevermind, sorry for the ping, I found a solution that keeps test compat

No worries

@Dreamsorcerer
Copy link

Dreamsorcerer commented Nov 14, 2023

@bdraco Just a reminder that a couple of hacks should be reverted for this release:

@bdraco
Copy link
Member Author

bdraco commented Nov 14, 2023

@bdraco Just a reminder that a couple of hacks should be reverted for this release:

Thanks for the reminder! Once we get it bumped for 3.11 as well, I'll pull those out.

edit: the first one can go now.

@bdraco bdraco changed the title Bump aiohttp to 3.9.0b1 for python 3.12 only Bump aiohttp to 3.9.0rc0 for python 3.12 only Nov 14, 2023
@bdraco bdraco marked this pull request as ready for review November 14, 2023 22:05
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 54c98f3 into dev Nov 15, 2023
53 checks passed
@frenck frenck deleted the aiohttp_390b1 branch November 15, 2023 00:02
@bdraco
Copy link
Member Author

bdraco commented Nov 15, 2023

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants