Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize radon units & add converter #103709

Closed
wants to merge 1 commit into from

Conversation

Kirchoff
Copy link
Contributor

@Kirchoff Kirchoff commented Nov 9, 2023

Breaking change

Proposed change

I am proposing that the few existing components that contain radon sensors be standardized. This includes airq, airthings, and airthings_ble. Each of these components handle units, state, and types differently. This PR aims to change that by introducing RADON as a SensorDeviceClass, as well as adding a standard unit converter, RadonConverter. This will allow users to set their own units, depending on their preference, instead of relying on the component to do so.

"Bq/m^3" is the standard SI units for measuring radon radioactivity concentration, "pCi/L" is the imperial equivalent used in the United States.

Please provide feedback if things should be implemented differently, and especially if/how new tests should be added for the new SensorDeviceClass.RADON and RadonConverter types.

Thank you.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Kirchoff
Copy link
Contributor Author

Kirchoff commented Nov 9, 2023

@bdraco - Thank you, discussion started.

@MartinHjelmare
Copy link
Member

Please open a new PR when the architecture discussion is approved. The initial PR here seems to have included unrelated commits that pinged a lot of contributors. If we keep this PR alive they will get spammed for every update to the PR. Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants