Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix yolink entity descriptions
I'm not able to test this live. However, the
dataclass
creation fails by just importing:With the fix in this PR, the dataclass creation works fine.
The problem is that the mixin has a field with a default value. Mixin classes are normally added to
EntityDescription
subclasses to make it possible to add fields without default values.yolink
is the only integration in core I could find which has such a mixin.It's possible to make the yolink pattern work by relying on dataclass inheritance if a parent adds a field with a default value.
However, relying on dataclass inheritance means it's no longer possible to create mutable dataclasses, so I'm not sure there's any benefit; any custom integration relying on the same pattern would still break unless the author change to frozen entity descriptions and we might break additional custom integrations.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: