-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assertion error when unloading ZHA with pollable entities #107311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: zha
small-pr
PRs with less than 30 lines.
labels
Jan 5, 2024
Hey there @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
puddly
approved these changes
Jan 5, 2024
frenck
pushed a commit
that referenced
this pull request
Jan 6, 2024
Merged
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Jan 6, 2024
…to v2024.1.2 (#294) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.1` -> `2024.1.2` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary> ### [`v2024.1.2`](https://github.com/home-assistant/core/releases/tag/2024.1.2) [Compare Source](home-assistant/core@2024.1.1...2024.1.2) - Fix support for play/pause functionality in System Bridge ([@​timmo001] - [#​103423]) ([system_bridge docs]) - Fix passing correct location id to streamlabs water ([@​joostlek] - [#​107291]) ([streamlabswater docs]) - Fix Shelly missing Gen value for older devices ([@​thecode] - [#​107294]) ([shelly docs]) - enigma2: fix exception when device in deep sleep, fix previous track ([@​autinerd] - [#​107296]) ([enigma2 docs]) - Fix assertion error when unloading ZHA with pollable entities ([@​dmulcahey] - [#​107311]) ([zha docs]) [#​103423]: home-assistant/core#103423 [#​106970]: home-assistant/core#106970 [#​107239]: home-assistant/core#107239 [#​107291]: home-assistant/core#107291 [#​107294]: home-assistant/core#107294 [#​107296]: home-assistant/core#107296 [#​107311]: home-assistant/core#107311 [@​autinerd]: https://github.com/autinerd [@​dmulcahey]: https://github.com/dmulcahey [@​frenck]: https://github.com/frenck [@​joostlek]: https://github.com/joostlek [@​thecode]: https://github.com/thecode [@​timmo001]: https://github.com/timmo001 [enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/ [shelly docs]: https://www.home-assistant.io/integrations/shelly/ [streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/ [system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/ [zha docs]: https://www.home-assistant.io/integrations/zha/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/294 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
integration: zha
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR corrects an issue with unloading ZHA when certain pollable entities are present. This fixes the linked issue below and the issue mentioned in this comment #105506 (comment)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: