-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry zoneminder connection setup #107519
Retry zoneminder connection setup #107519
Conversation
Makes ZM setup be async for enabling connection retry attempts This also requires zm-py version bump v0.5.4 as that dependency was patched in conjunction to resolve this issue Closes home-assistant#105271 Signed-off-by: Nic Boet <nic@boet.cc>
Hey there @rohankapoorcom, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Signed-off-by: Nic Boet <nic@boet.cc>
Signed-off-by: Nic Boet <nic@boet.cc>
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Signed-off-by: Nic Boet <nic@boet.cc>
Signed-off-by: Nic Boet <nic@boet.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Makes ZM setup be async for enabling connection retry attempts
This also requires zm-py version bump v0.5.4 as that dependency was patched in conjunction to resolve this issue
Closes #105271
Proposed change
Enable setup connection retry within the ZoneMinder component
Type of change
Yes, both are needed to resolve the issue
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: