-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicated resource issue in System Monitor #107671
Fix duplicated resource issue in System Monitor #107671
Conversation
Is this not a breaking change, as it changes the ID's? |
It's not changing the id's. It's just for comparisons to know which entities to make or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx @gjohansson-ST 👍
* Fix duplicated resource issue * Only slug the argument
Hi, No more yaml with these sensors ... |
It can be the old entities need to be removed. |
Please also look at disabled entities |
See #107903 |
Proposed change
Given that arguments can be typed in many ways it results in duplicated unique id's.
Slugify the loaded resources in the comparison to avoid this.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: