Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sleep period for Shelly devices with buggy fw #107961

Merged
merged 7 commits into from
Jan 13, 2024

Conversation

chemelli74
Copy link
Contributor

Breaking change

Proposed change

Update sleep period for Shelly devices with buggy fw

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

MODEL_HT,
]:
expected_sleep_period = 42300
LOGGER.warning(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LOGGER.warning(
LOGGER.info(

I think this can be in info level, no need to warn the user as there is no action needed from the user side we can silently update the value and it will still be visible if we ask for logs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many users have a default level of WARNING, this is why I prefer to make it visibile.
Anyway is a single shot, not a recurring one so if not visible the first time is lost.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a warning should only be visible if there is something that the user needs to take care about (connection error, something that is configured incorrectly or doesn't work).

I had multiple times when I was asked in PRs to reduce the level not to make users worry about things they can't control or need to inform us.

In any case if another code-owner thinks this should be warning let's keep it as warning.

Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change is to move the block before we init the device and fix the test, constants would be nice

homeassistant/components/shelly/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/shelly/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/shelly/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/shelly/__init__.py Outdated Show resolved Hide resolved
tests/components/shelly/test_init.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 13, 2024 20:00
@chemelli74 chemelli74 marked this pull request as ready for review January 13, 2024 21:26
@home-assistant home-assistant bot requested a review from thecode January 13, 2024 21:26
@chemelli74 chemelli74 added this to the 2024.1.4 milestone Jan 13, 2024
@chemelli74 chemelli74 merged commit ef8d394 into home-assistant:dev Jan 13, 2024
23 checks passed
@chemelli74 chemelli74 deleted the chemelli74-shelly-fix-sleep branch January 13, 2024 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shelly Door/Window 2 becoming "unavailable" until reload of Shelly Integration
6 participants