-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sleep period for Shelly devices with buggy fw #107961
Update sleep period for Shelly devices with buggy fw #107961
Conversation
Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MODEL_HT, | ||
]: | ||
expected_sleep_period = 42300 | ||
LOGGER.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOGGER.warning( | |
LOGGER.info( |
I think this can be in info level, no need to warn the user as there is no action needed from the user side we can silently update the value and it will still be visible if we ask for logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many users have a default level of WARNING, this is why I prefer to make it visibile.
Anyway is a single shot, not a recurring one so if not visible the first time is lost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a warning should only be visible if there is something that the user needs to take care about (connection error, something that is configured incorrectly or doesn't work).
I had multiple times when I was asked in PRs to reduce the level not to make users worry about things they can't control or need to inform us.
In any case if another code-owner thinks this should be warning let's keep it as warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main change is to move the block before we init the device and fix the test, constants would be nice
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Breaking change
Proposed change
Update sleep period for Shelly devices with buggy fw
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: