Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we fix the default instead so that it's never
None
?Also, we should not use
dict.get
on line 157 since we know that the key will exist in the dict.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. This change was the simplest way I could see to "fix" the issue without risking breaking something else.
I don't understand why the name is ever asked for, which is the real reason this issue ever existed. It's asked once on setup then can never be configured again.
To be honest, I also don’t understand why the MJPEG variant of Generic Camera exists at all - shouldn't MJPEG cameras simply work in the Generic Camera?