Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send target temp to Shelly TRV in F when needed #108188

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

jra3
Copy link
Contributor

@jra3 jra3 commented Jan 16, 2024

Breaking change

Proposed change

Send updates to target_temperature to shelly TRV in Fahrenheit when appropriate. Shelly TRVs can be updated by setting a new target temperature via an HTTP GET request like this http://10.20.30.40/thermostat/0?target_t_enabled=1&target_t=22. There is, however, no unit attached to this request, and the internals of this shelly integration are made to always deal with C (a sensible default).

The behavior I see as a US user is that I can view the current state of the target temperature properly in a climate entity card, but any change, (Say to 70F) will be sent to the TRV in C (target_t=20). My TRVs are set to expect F, so they get the 20, and replace it with the hard-coded minimum of 40F. Any change to the climate entity target temp in HA will result in the TRV being set to 40F in fact because the highest value the integration will send to the TRV is target_t=31 (see: SHTRV_01_TEMPERATURE_SETTINGS)

This change allows us to look at how the TRV is configured (at least as of the time the integration was (re)loaded) and convert C->F only if the TRV expects F.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @balloob, @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good but I can't test it would be nice to get confirmation from one of the other code owners who has TRV

@bieniu
Copy link
Member

bieniu commented Jan 17, 2024

I will be able to test this in the afternoon or evening.

Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with metric and imperial units, everything seems to work fine. Thanks.

@thecode thecode added this to the 2024.1.4 milestone Jan 17, 2024
@thecode thecode merged commit a385ca9 into home-assistant:dev Jan 17, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants