-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send target temp to Shelly TRV in F when needed #108188
Conversation
Hey there @balloob, @bieniu, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
e504d23
to
de8c7c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good but I can't test it would be nice to get confirmation from one of the other code owners who has TRV
I will be able to test this in the afternoon or evening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with metric and imperial units, everything seems to work fine. Thanks.
Breaking change
Proposed change
Send updates to target_temperature to shelly TRV in Fahrenheit when appropriate. Shelly TRVs can be updated by setting a new target temperature via an HTTP GET request like this
http://10.20.30.40/thermostat/0?target_t_enabled=1&target_t=22
. There is, however, no unit attached to this request, and the internals of this shelly integration are made to always deal with C (a sensible default).The behavior I see as a US user is that I can view the current state of the target temperature properly in a climate entity card, but any change, (Say to 70F) will be sent to the TRV in C (target_t=20). My TRVs are set to expect F, so they get the 20, and replace it with the hard-coded minimum of 40F. Any change to the climate entity target temp in HA will result in the TRV being set to 40F in fact because the highest value the integration will send to the TRV is
target_t=31
(see: SHTRV_01_TEMPERATURE_SETTINGS)This change allows us to look at how the TRV is configured (at least as of the time the integration was (re)loaded) and convert C->F only if the TRV expects F.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: