-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump yolink-api to 0.3.6 fix aiomqtt breaking changes #108555
Conversation
This dependency bump fixes on a fixed version of |
Is there any way to lock the versions of dependencies to prevent third-party library dependency updates from causing integration failures? |
You could set an upper limit on the major version, however, that makes assumptions on the versioning as well (there are many different strategies). In general, the best way to handle things like this: is ensuring it works in tests. |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will this fix be released? This error will cause a large number of client reconnections. In addition to users being unable to use it normally, it will also occupy a large number of server connections. |
@matrixd2 I didn't realize that you bumped the dependency and have resolved my comment. This looks good. |
Proposed change
Fix aiomqtt breaking changes
YoSmart-Inc/yolink-api@v0.3.4...v0.3.6
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: