Reduce log level for creating ZHA cluster handler #108809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This lowers the log level for creating a ZHA cluster handler from
info
todebug
.IMO, there's little to no value in seeing many lines of ZHA creating cluster handlers during startup, even when you choose to see the more verbose
info
log level (instead of the defaultwarning
level).As an example, starting my production HA instance with ~150 ZHA devices causes this: https://dpaste.org/ah7Mu
So, a total of 1160 lines of logging just for ZHA cluster handlers. Generally, the
info
logging isn't spammy otherwise.The logs were added with the ZHA refactor PR: #91476
I've left this in draft for now. Maybe there's a good reason this was added to
info
instead ofdebug
in the first place?"Warning" log
Note: If a cluster handler can't be created, a (more important)
warning
will still be logged:core/homeassistant/components/zha/core/endpoint.py
Lines 141 to 145 in df9faea
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: