Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiopegelonline to 0.0.8 #110274

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Feb 11, 2024

Proposed change

On slower systems, during start up of HA many tasks will be scheduled and HA has it's own timeout parameters. These parameters should ensure, that waiting for task to be started is different from waiting for a client session to get response. These timeouts were override by the lib, which caused an overall timeout of the setup task.
In HA we use the DEFAULT_TIMEOUT which is 300s, since this was overwritten by the lib with 10s, on slow systems timeouts during start up of HA might occur.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@mib1185 mib1185 merged commit ce37b84 into home-assistant:dev Feb 11, 2024
53 checks passed
@mib1185 mib1185 deleted the pegel_online/bump-lib branch February 11, 2024 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pegelonline failing on HA restart
3 participants