-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add light color temperature intent support #113980
Add light color temperature intent support #113980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Moonlight63
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
4f7c54c
to
c916d85
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
@Moonlight63 the PR has merge conflicts, please fix them |
Closing this in favor of #118321 which adds |
Thank you for sorting that. I hadn't gotten a chance to change to the new system. |
Proposed change
This is step one to resolving a feature request for voice assist to support changing the color temperature of lights. We can change color, but color temperature is a different operation. I had a need for this myself, but there is also an open feature request for it here: home-assistant/intents#2059
Step two of this process will be to implement the intent sentence, but this function has to be available in core first because otherwise the intent has nothing to call :)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: