-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ecobee ventilator 20 min timer #115969
Add ecobee ventilator 20 min timer #115969
Conversation
@PeteRager @joostlek just updated the code to remove the part that was an anti-pattern. Note the behaviours are exactly the same. Switch works like extended |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
For this branch to work, we need an updated python-ecobee-api lib. Waiting for merge |
@MartinHjelmare your comments have been addressed, the lib is updated. So should work with TZ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!
@MartinHjelmare Link added in PR header and code adjusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
Add ventilator 20 min timer switch. To replicate a feature of the physical device (Ecobee).
This option starts a 20 min timer for the ventilator. The ventilator will run for 20 min and the stop.
This requires to add a new Platform (Switch) that was not use yet in this integration.
Sadly the API of Ecobee is not ideal, to detect if the switch is on you have to look if the
ventilatorOffDateTime
is in the future.To get the correct time, we need the timezone info from the thermostat. An update of the underlying library connecting to Ecobee was required:
To turn it on or off, we have to reset the value of
set_ventilator_timer
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: