Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecobee ventilator 20 min timer #115969

Conversation

marcolivierarsenault
Copy link
Contributor

@marcolivierarsenault marcolivierarsenault commented Apr 22, 2024

Proposed change

Add ventilator 20 min timer switch. To replicate a feature of the physical device (Ecobee).

This option starts a 20 min timer for the ventilator. The ventilator will run for 20 min and the stop.

This requires to add a new Platform (Switch) that was not use yet in this integration.

Sadly the API of Ecobee is not ideal, to detect if the switch is on you have to look if the ventilatorOffDateTime is in the future.
To get the correct time, we need the timezone info from the thermostat. An update of the underlying library connecting to Ecobee was required:

To turn it on or off, we have to reset the value of set_ventilator_timer

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. Diff of lib python-ecobee-api
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@marcolivierarsenault
Copy link
Contributor Author

Just for context I am trying to mimic the real device behaviour

As you can see the ventilator is running. (Because of min ventilator setting)
image

But the 20 min switch is off image

The 20 min switch is what I am trying to go here

@marcolivierarsenault
Copy link
Contributor Author

@PeteRager @joostlek just updated the code to remove the part that was an anti-pattern.

Note the behaviours are exactly the same. Switch works like extended

@MartinHjelmare MartinHjelmare changed the title Add ventilator 20 min timer Add ecobee ventilator 20 min timer Apr 30, 2024
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 30, 2024 06:47
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@marcolivierarsenault
Copy link
Contributor Author

For this branch to work, we need an updated python-ecobee-api lib. Waiting for merge

@marcolivierarsenault
Copy link
Contributor Author

@MartinHjelmare your comments have been addressed, the lib is updated. So should work with TZ

@marcolivierarsenault marcolivierarsenault marked this pull request as ready for review May 1, 2024 18:23
@home-assistant home-assistant bot requested a review from MartinHjelmare May 1, 2024 18:23
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 2, 2024 10:00
@marcolivierarsenault
Copy link
Contributor Author

@MartinHjelmare Link added in PR header and code adjusted

@marcolivierarsenault marcolivierarsenault marked this pull request as ready for review May 2, 2024 11:13
@home-assistant home-assistant bot requested a review from MartinHjelmare May 2, 2024 11:13
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 0e23d04 into home-assistant:dev May 3, 2024
38 checks passed
@marcolivierarsenault marcolivierarsenault deleted the add_ventilator_20_min_timer branch May 3, 2024 00:11
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants