Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSO Energy services #118770

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Conversation

osohotwateriot
Copy link
Contributor

@osohotwateriot osohotwateriot commented Jun 4, 2024

Breaking change

Add custom services for OSO Energy

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@austinmroczek austinmroczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment.

homeassistant/components/osoenergy/strings.json Outdated Show resolved Hide resolved
tests/components/osoenergy/conftest.py Outdated Show resolved Hide resolved
tests/components/osoenergy/conftest.py Outdated Show resolved Hide resolved
tests/components/osoenergy/test_water_heater.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Sep 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 8, 2024 11:29
@osohotwateriot osohotwateriot marked this pull request as ready for review September 11, 2024 13:41
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

Some additional comments and questions though.

tests/components/osoenergy/test_water_heater.py Outdated Show resolved Hide resolved
tests/components/osoenergy/test_water_heater.py Outdated Show resolved Hide resolved
homeassistant/components/osoenergy/water_heater.py Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a check question: Is it expected that the water heater's profile shifts by one local hour when entering or leaving DST?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the timezones where the clock changes due to the DST the local profile will also change according to the new offset of the time against UTC. That will be reflected at the moment the get_profile action is used.

Copy link
Contributor

@emontnemery emontnemery Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words: it is expected that the profile shifts by one local hour when DST starts or ends?

As an example, if I set the profile to higher temperature between 08:00 ~ 18:00 during normal time, the profile will shift to higher temperature 09:00 ~ 19:00 at the start of DST?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is correct.

@home-assistant home-assistant bot marked this pull request as draft October 16, 2024 09:26
@osohotwateriot osohotwateriot marked this pull request as ready for review October 17, 2024 13:39
@home-assistant home-assistant bot requested a review from emontnemery October 17, 2024 13:39
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @osohotwateriot 👍

@emontnemery emontnemery merged commit cdf8099 into home-assistant:dev Oct 22, 2024
32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants