Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pylint on tests #119279

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Enable pylint on tests #119279

merged 2 commits into from
Jun 20, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jun 10, 2024 •
edited
Loading

Proposed change

All pylint errors have been cleaned up from tests folder.
In order to help with reviews, I propose that we enable pylint on the CI.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Jun 10, 2024
This was referenced Jun 10, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Jun 10, 2024
Merged
Merged
This was referenced Jun 10, 2024
Merged
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@epenet epenet mentioned this pull request Jun 14, 2024
Merged
20 tasks
@epenet epenet force-pushed the 20240610-1141 branch 2 times, most recently from 2f2e51a to 9706b10 Compare June 14, 2024 07:16
@epenet epenet mentioned this pull request Jun 14, 2024
Merged
20 tasks
@epenet epenet changed the title Do not merge: Enable pylint on tests Enable pylint on tests Jun 14, 2024
@epenet epenet marked this pull request as ready for review June 14, 2024 11:58
@epenet epenet requested a review from a team as a code owner June 14, 2024 11:58
epenet
epenet commented Jun 14, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@epenet epenet mentioned this pull request Jun 17, 2024
Merged
20 tasks
@epenet epenet mentioned this pull request Jun 17, 2024
Merged
20 tasks
@epenet epenet force-pushed the 20240610-1141 branch 2 times, most recently from 1b992fb to 1928949 Compare June 18, 2024 10:01
This was referenced Jun 18, 2024
Merged
Merged
@epenet epenet force-pushed the 20240610-1141 branch 2 times, most recently from 81131e7 to c12ce11 Compare June 20, 2024 10:11
edenhaus
edenhaus reviewed Jun 20, 2024
View reviewed changes
.github/workflows/ci.yaml
@@ -620,6 +620,51 @@ jobs:
python --version
pylint --ignore-missing-annotations=y homeassistant/components/${{ needs.info.outputs.integrations_glob }}

pylint-tests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need an additional job for it? Can we not extend the pylint job, or is the execution time that bad?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylint is one of the longer jobs... about 10 minutes for main and 10 minutes for tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #120022 to compare the run times

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 jobs: 8m 18s + 5m 58s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a single job... still running after 19 minutes
https://github.com/home-assistant/core/actions/runs/9598111761/job/26468675380?pr=120022

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does pylint have some kind of cache?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just wondering but it looks like one job takes a lot longer so we should use two jobs

edenhaus
edenhaus reviewed Jun 20, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@epenet epenet mentioned this pull request Jun 20, 2024
Closed
20 tasks
edenhaus
edenhaus approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epenet 👍

@epenet epenet merged commit 325a49e into home-assistant:dev Jun 20, 2024
39 checks passed
@epenet epenet deleted the 20240610-1141 branch June 20, 2024 14:02
@zxdavb zxdavb mentioned this pull request Jun 21, 2024
Merged
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek left review comments

@edenhaus edenhaus edenhaus approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epenet @joostlek @edenhaus