-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic user info API #120811
Add basic user info API #120811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to further expand our Rest API and we already have this command available via the WebSocket API: https://github.com/home-assistant/core/blob/dev/homeassistant/components/auth/__init__.py#L484
then is it not possible at all to make that ws api to also available as rest api? i find it very weird that you can query via ws and not rest. ws isnt even supposed to be a “request response” communication. |
nevermind this PR. i will just use the websocket API even though it is weird and makes things unnecessarily more complicated. also the current user command is not even documented in the docs. |
Proposed change
To support the authorization with vouch-proxy, i need an api to get the current user's name so that i can select which users in my HA can log in to my other apps.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: