Add new QNAP QSW uptime timestamp sensor #122589
Conversation
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
home-assistant
bot
added
cla-signed
has-tests
integration: qnap_qsw
new-feature
small-pr
Noltari
changed the title
|
Why do we have 2 entities for this now? I prefer the date time one more since it doesn't write state every update |
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This reverts commit 1bdab4e.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
| "uptime": { | ||
| "name": "Uptime" | ||
| }, | ||
| "uptime_timestamp": { | ||
| "name": "Uptime timestamp" | ||
| } |
There was a problem hiding this comment.
Hmm, something in me things uptime is viable for both, but I'm not sure what is best here
There was a problem hiding this comment.
I'm happy with both, so I can change it to use uptime for both if you prefer that.
There was a problem hiding this comment.
The only downside is that they'll both be called uptime so one will be appended _2
There was a problem hiding this comment.
The only downside is that they'll both be called uptime so one will be appended
_2
Ah, you're right, and we won't be able to tell them appart for uptime_seconds_deprecated...
There was a problem hiding this comment.
I've asked for a second opinion on this.
But also keep in mind, people could've renamed both the name and entity id, so it could but even be recognizable
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
frenck
added
the
smash
|
Failure in codecov not related to changes: |
|
Thanks @joostlek! |
Breaking change
QNAP QSW uptime seconds sensor has been replaced by an uptime timestamp sensor.
Proposed change
Add new QNAP QSW uptime timestamp sensor.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: