Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VIZIO power and source change issues #124013

Closed
wants to merge 1 commit into from

Conversation

asportnoy
Copy link

Proposed change

This PR fixes some issues I've had with the VIZIO integration I've had on my TV (a V-Series). I have been running this changed code in a "forked" version of the integration for a few months now and finally got around to PRing it.

  • Switching to HDMI input sources didn't work at all. I found out that this was because the format of the input source was incorrect and needs to be hdmi1 instead of HDMI-1.
  • I had issues with turning power on within automations where it would not properly handle a case where it was already on. I added a check of the existing power state before changing it.

Python is not my strong suit, so please let me know if there's a better way some of these things could be done.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Fixes #83689 (went stale). There are probably other older issues as well but none are currently open.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asportnoy

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @raman325, mind taking a look at this pull request as it has been labeled with an integration (vizio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vizio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vizio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@asportnoy asportnoy marked this pull request as ready for review August 15, 2024 22:50
@MartinHjelmare MartinHjelmare changed the title [VIZIO] Fix power and source change issues Fix VIZIO power and source change issues Aug 16, 2024
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the PR in 2 since it fixes 2 bugs

@home-assistant home-assistant bot marked this pull request as draft August 18, 2024 13:50
@asportnoy
Copy link
Author

asportnoy commented Aug 22, 2024

@joostlek I don't have the time to deal with opening a separate PR right now. Someone else can feel free to take over this if you want the fixes merged.

I know @raman325 mentioned previously he doesn't have a VIZIO TV to troubleshoot/test with, so hopefully this PR has the info he needs to implement the fix himself if he wants.

If I have time, I may be able to deal with opening a separate PR, but it's a lot of overhead for a 5 line bug fix.

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Oct 21, 2024
@asportnoy
Copy link
Author

Feel free to take my code and PR yourself as mentioned above. But I simply don't have the time to deal with the overhead required to PR such a trivial fix myself. So I guess I'll close this PR for now.

@asportnoy asportnoy closed this Oct 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vizio Smartcast Integration cannot use media_player select source for anything not a TV "app"
3 participants