-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VIZIO power and source change issues #124013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @asportnoy
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @raman325, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split the PR in 2 since it fixes 2 bugs
@joostlek I don't have the time to deal with opening a separate PR right now. Someone else can feel free to take over this if you want the fixes merged. I know @raman325 mentioned previously he doesn't have a VIZIO TV to troubleshoot/test with, so hopefully this PR has the info he needs to implement the fix himself if he wants. If I have time, I may be able to deal with opening a separate PR, but it's a lot of overhead for a 5 line bug fix. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Feel free to take my code and PR yourself as mentioned above. But I simply don't have the time to deal with the overhead required to PR such a trivial fix myself. So I guess I'll close this PR for now. |
Proposed change
This PR fixes some issues I've had with the VIZIO integration I've had on my TV (a V-Series). I have been running this changed code in a "forked" version of the integration for a few months now and finally got around to PRing it.
hdmi1
instead ofHDMI-1
.Python is not my strong suit, so please let me know if there's a better way some of these things could be done.
Type of change
Additional information
Fixes #83689 (went stale). There are probably other older issues as well but none are currently open.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: