-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Acmeda integration #124960
base: dev
Are you sure you want to change the base?
Fix Acmeda integration #124960
Conversation
…ment battery health monitoring.
Resolve issue home-assistant#123509 due to calls to async_write_ha_state from a thread other than the event loop Bump aiopulse version to 0.4.6 to fix issues with hub timers as well as unicode characters in strings.
Convert unique_id to string
Revert changes to config_flow that broke hub discovery.
Updated aiopulse to 0.4.6 from 0.4.4
Resolved ruff issue with PERF401
Removed unused type: ignore comment
Pretty manifest.json
Can we try splitting some bug fixes in different PRs? Haven't read the code yet, but having a non string unique id usually requires a migration |
This reverts commit 68f52ea.
Done, reverted changes to unique_id |
Awesome, can we also do the bump in a separate PR? :) |
Done |
I think the comments from bdraco mean that we should refactor the library to remove the extra async loop stuff and because the library is async we don't have to worry about running non-async code |
Have reverted the change to the notification callback and submitted a pull request to resolve that separate issue: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an merge conflict, could you take a look?
..?Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Breaking change
Proposed change
As part of homeassistant code refactoring changes were made to the acmeda integration that broke the integration when discovering new hubs. This pull request fixes the discovery of hubs and other reported defects:
Type of change
Additional information
Rollease Acmeda integration fails with "UnboundLocalError: cannot access local variable 'hubs' where it is not associated with a value" #124025
Cannot add integration from 2024.7.0 onwards (Rollease Acmeda Automate integration) #123510
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: