-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partstat to CalendarEvent #125708
Add partstat to CalendarEvent #125708
Conversation
When working with calendar events, it can be useful to filter by response status. For example, one might want to hide events that have been declined. This PR adds a `partstate` field to CalendarEvent in line with rfc5545.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -347,6 +363,7 @@ class CalendarEvent: | |||
summary: str | |||
description: str | None = None | |||
location: str | None = None | |||
partstat: str | None = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is changing our entity model. Before we can review this PR there needs to be approval in a discussion in our architecture repository.
https://github.com/home-assistant/architecture/discussions
https://developers.home-assistant.io/docs/core/entity#changing-the-entity-model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I missed those docs! Done: home-assistant/architecture#1137 ❤️
Closing in favor of #128900 |
Proposed change
When working with calendar events, it can be useful to filter by response status. For example, one might want to hide events that have been declined. This PR adds a
partstat
field to CalendarEvent per rfc5545. If accepted, I will follow up with setting this value in the Google Calendar integration ❤️Type of change
Additional information
N/A
Checklist
ruff format homeassistant tests
)I did not immediately see any tests for this object. I'd be happy to look at adding them if pointed in the right direction!
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: