Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new state property for alarm_control_panel which is using an enum #126283

Merged
merged 33 commits into from
Oct 21, 2024

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Sep 19, 2024

Proposed change

Implement separate state property for alarm_control_panel which returns AlarmControlPanelEntityState enum
Architectural decision: home-assistant/architecture#1140
Dev docs PR: home-assistant/developers.home-assistant#2361

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (alarm_control_panel) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of alarm_control_panel can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign alarm_control_panel Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gjohansson-ST gjohansson-ST marked this pull request as ready for review October 21, 2024 15:48
@home-assistant home-assistant bot dismissed stale reviews from themself October 21, 2024 15:48

Stale

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gjohansson-ST
Copy link
Member Author

Test fix in #128943 (which isn't related to this PR)

@gjohansson-ST gjohansson-ST merged commit cdfec7e into dev Oct 21, 2024
41 of 42 checks passed
@gjohansson-ST gjohansson-ST deleted the alarm-state-is-enum branch October 21, 2024 20:54
@Hofyyy
Copy link

Hofyyy commented Oct 22, 2024

Hello, how can I see if this made it into stable?

@gjohansson-ST
Copy link
Member Author

Hello, how can I see if this made it into stable?

It's in the next release which is 2024.11.0

@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@frenck frenck removed this from the 2024.11.0b0 milestone Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants