Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tplink number platform to use intended BOX mode #126397

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Fix tplink number platform to use intended BOX mode #126397

merged 1 commit into from
Sep 21, 2024

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Sep 21, 2024 •
edited
Loading

Proposed change

The NumberMode should be BOX as per the entity description but due to the missing dataclass decorator was resolving to NumberMode.AUTO. This PR fixes that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rytilahti, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@sdb9696 sdb9696 mentioned this pull request Sep 21, 2024
Merged
19 tasks
rytilahti
rytilahti approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sdb9696!

@rytilahti rytilahti merged commit 556deb4 into home-assistant:dev Sep 21, 2024
31 checks passed
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 21, 2024
@sdb9696 @zxdavb
Fix tplink number platform to use intended BOX mode (home-assistant#1…
f723cdb 
…26397)

The NumberMode should be BOX as per the entity description but due to the missing dataclass decorator was resolving to NumberMode.AUTO.
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 21, 2024
@sdb9696 @zxdavb
Fix tplink number platform to use intended BOX mode (home-assistant#1…
403391e 
…26397)

The NumberMode should be BOX as per the entity description but due to the missing dataclass decorator was resolving to NumberMode.AUTO.
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 21, 2024
@sdb9696 @zxdavb
Fix tplink number platform to use intended BOX mode (home-assistant#1…
f222109 
…26397)

The NumberMode should be BOX as per the entity description but due to the missing dataclass decorator was resolving to NumberMode.AUTO.
zxdavb added a commit to zxdavb/hass that referenced this pull request Sep 21, 2024
@zxdavb
Squashed commit of the following:
184bfb5 
commit a6651d8
Merge: 359a53a a923f15
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sun Sep 22 00:06:35 2024 +0100

    commit

commit 359a53a
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 23:29:41 2024 +0100

    Rename some evohome constants for clarity / readability (home-assistant#126394)

    initial commit

commit 553e9bc
Author: Erik Montnemery <erik@montnemery.com>
Date:   Sat Sep 21 23:14:12 2024 +0200

    Add issue asking users to disable ESPHome assist_in_progress sensor (home-assistant#125805)

    * Add issue asking users to disable ESPHome assist_in_progress binary sensor

    * Include integration name in title and description

    * Add repair flow

    * Improve test coverage

commit 6792aea
Author: Michael <35783820+mib1185@users.noreply.github.com>
Date:   Sat Sep 21 21:11:17 2024 +0200

    Set connection and command timeout in VLC Telnet (home-assistant#126401)

    use 1s lower than scan interval

commit 45d5021
Author: Allen Porter <allen@thebends.org>
Date:   Sat Sep 21 10:56:13 2024 -0700

    Update the Google Photos integration to limit scope to Home Assistant created content (home-assistant#126398)

commit f222109
Author: Steven B. <51370195+sdb9696@users.noreply.github.com>
Date:   Sat Sep 21 18:03:51 2024 +0100

    Fix tplink number platform to use intended BOX mode (home-assistant#126397)

    The NumberMode should be BOX as per the entity description but due to the missing dataclass decorator was resolving to NumberMode.AUTO.

commit eddb698
Merge: 5a9a19c 2410611
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 15:47:58 2024 +0100

    Merge remote-tracking branch 'upstream/dev' into evo_fix_visionpro

commit 5a9a19c
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 13:37:29 2024 +0100

    un-rename symbols

commit dfe44a1
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 11:40:19 2024 +0100

    move attr to all children of TCS

commit f16565e
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 11:22:12 2024 +0100

    remove tests (for now)

commit 8936c7b
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 11:19:40 2024 +0100

    tweaks to codes

commit be711f5
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 09:31:29 2024 +0100

    Add tests of services and entity methods

commit 862b097
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 09:21:52 2024 +0100

    Refactor evohome for visionpro modes,

commit 5eec2d0
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 09:20:19 2024 +0100

    Improve test suit - setup/teardown, use generator, rename symbols
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2024
@sdb9696 sdb9696 deleted the fix/tplink_number_box branch October 18, 2024 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rytilahti rytilahti rytilahti approved these changes

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

@rytilahti rytilahti

Labels
bugfix by-code-owner cla-signed has-tests integration: tplink Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdb9696 @rytilahti @bdraco