Add Tesla Fleet grid status #126438

JEMcats · 2024-09-22T16:24:17Z

Proposed change

This pull request adds 2 changes:

Grid Connected / Disconnected Status ('Unknown'/'Connected'/'Disconnected'/'Disconnected intentionally' )
Storm Watch Active / Standby ('True'/'False')

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR is related to PR: #126003

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

Updated Docs

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2024-09-22T16:24:23Z

Hey there @Bre77, mind taking a look at this pull request as it has been labeled with an integration (tesla_fleet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tesla_fleet can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign tesla_fleet Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Bre77

Only a couple of small changes. Thanks!

homeassistant/components/tesla_fleet/icons.json

homeassistant/components/tesla_fleet/sensor.py

Bre77

Sorry one last thing I missed, Added a suggestion you should just be able to commit.

homeassistant/components/tesla_fleet/sensor.py

home-assistant · 2024-09-24T07:35:27Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

…o tesla-status

Bre77 · 2024-09-24T23:59:53Z

@JEMcats run pytest ./tests/components/tesla_fleet --snapshot-update in your dev environment to update the test snapshots and commit the binary_sensory.ambr file it will update.

Bre77 · 2024-09-25T00:06:46Z

You can use this as your documentation: home-assistant/home-assistant.io#34911

Bre77

Generate testing snapshot and add documentation link to the PR description.

…o tesla-status

Bre77 · 2024-09-25T01:37:06Z

@JEMcats sorry I made a bad assumption that your translations would be up to date. Delete the *.ambr files you generated, run script/setup then re-run the pytest command, this should generate some entries in sensors.ambr for the grid status entity only.

JEMcats · 2024-09-25T19:38:51Z

I completed those steps and there is nothing new to commit.

gjohansson-ST

Delete the snapshot files, run compile translations and then regenerate the translation files so it gets up to date.

tests/components/tesla_fleet/snapshots/test_button.ambr

tests/components/tesla_fleet/snapshots/test_lock.ambr

JEMcats · 2024-09-25T20:01:28Z

I compiled the translations and updated the *.ambr files. d8f61c0

gjohansson-ST · 2024-09-25T20:04:49Z

homeassistant/components/tesla_fleet/strings.json

+ "island_status_unknown": "Unknown",
+ "on_grid": "Connected",
+ "off_grid": "Disconnected",
+ "off_grid_unintentional": "Disconnected",


Should this really be translated same as the one above?

I don't think it should be, I'd suggest adding the intentional / unintentional aspect to the translation.

are you talking about off_grid and off_grid_unintentional?

If the key name contains unintentional I guess it would be logic to add that as a word to the translation.

JEMcats added 2 commits September 22, 2024 15:57

Make Changes.

700531b

Merge branch 'home-assistant:dev' into tesla-status

622a517

home-assistant bot added cla-signed integration: tesla_fleet new-feature Quality Scale: gold labels Sep 22, 2024

JEMcats changed the title ~~Add Grid Status, And Storm Watch Active Status.~~ Add Grid And Storm Watch Active Status. Sep 22, 2024

JEMcats mentioned this pull request Sep 22, 2024

Add Tesla Fleet Energy History #126003

Open

19 tasks

Bre77 suggested changes Sep 22, 2024

View reviewed changes

homeassistant/components/tesla_fleet/icons.json Show resolved Hide resolved

homeassistant/components/tesla_fleet/sensor.py Outdated Show resolved Hide resolved

Change to match suggested changes.

a682d25

Bre77 suggested changes Sep 22, 2024

View reviewed changes

homeassistant/components/tesla_fleet/sensor.py Outdated Show resolved Hide resolved

JEMcats added 2 commits September 22, 2024 22:07

add Possible States to island status

8ef08a5

Merge branch 'dev' into tesla-status

3ea3278

Bre77 approved these changes Sep 22, 2024

View reviewed changes

MartinHjelmare changed the title ~~Add Grid And Storm Watch Active Status.~~ Add Tesla Fleet grid and storm watch active status Sep 22, 2024

JEMcats added 2 commits September 23, 2024 15:27

Merge branch 'dev' into tesla-status

8592333

Merge branch 'dev' into tesla-status

bf73ec8

gjohansson-ST requested changes Sep 24, 2024

View reviewed changes

homeassistant/components/tesla_fleet/sensor.py Outdated Show resolved Hide resolved

home-assistant bot marked this pull request as draft September 24, 2024 07:35

JEMcats added 3 commits September 24, 2024 23:55

remove storm watch active sensor.

6eb19f6

Merge branch 'tesla-status' of https://github.com/JEMcats/ha-core int…

f360955

…o tesla-status

Merge branch 'dev' into tesla-status

83b6f72

JEMcats changed the title ~~Add Tesla Fleet grid and storm watch active status~~ Add Tesla Fleet grid status Sep 24, 2024

JEMcats marked this pull request as ready for review September 24, 2024 23:56

home-assistant bot requested review from Bre77 and gjohansson-ST September 24, 2024 23:57

Bre77 mentioned this pull request Sep 25, 2024

Add Grid status sensor to Tesla Fleet home-assistant/home-assistant.io#34911

Open

8 tasks

Bre77 suggested changes Sep 25, 2024

View reviewed changes

JEMcats added 2 commits September 25, 2024 00:19

Update the test_*.ambr files

5791fb1

Merge branch 'tesla-status' of https://github.com/JEMcats/ha-core int…

30e8cec

…o tesla-status

Merge branch 'dev' into tesla-status

8445970

gjohansson-ST requested changes Sep 25, 2024

View reviewed changes

tests/components/tesla_fleet/snapshots/test_button.ambr Outdated Show resolved Hide resolved

tests/components/tesla_fleet/snapshots/test_lock.ambr Outdated Show resolved Hide resolved

home-assistant bot marked this pull request as draft September 25, 2024 19:53

JEMcats added 2 commits September 25, 2024 19:59

Update *.ambr files

d8f61c0

Merge branch 'dev' into tesla-status

952c30c

JEMcats marked this pull request as ready for review September 25, 2024 20:03

home-assistant bot requested review from Bre77 and gjohansson-ST September 25, 2024 20:03

gjohansson-ST requested changes Sep 25, 2024

View reviewed changes

home-assistant bot marked this pull request as draft September 25, 2024 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Tesla Fleet grid status #126438

Add Tesla Fleet grid status #126438

JEMcats commented Sep 22, 2024 •

edited

Loading

home-assistant bot commented Sep 22, 2024

Bre77 left a comment

Bre77 left a comment

home-assistant bot commented Sep 24, 2024

Bre77 commented Sep 24, 2024

Bre77 commented Sep 25, 2024

Bre77 left a comment

Bre77 commented Sep 25, 2024

JEMcats commented Sep 25, 2024

gjohansson-ST left a comment

JEMcats commented Sep 25, 2024 •

edited

Loading

gjohansson-ST Sep 25, 2024

Bre77 Sep 25, 2024

JEMcats Sep 25, 2024

gjohansson-ST Sep 25, 2024

Add Tesla Fleet grid status #126438

Are you sure you want to change the base?

Add Tesla Fleet grid status #126438

Conversation

JEMcats commented Sep 22, 2024 • edited Loading

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented Sep 22, 2024

Bre77 left a comment

Choose a reason for hiding this comment

Bre77 left a comment

Choose a reason for hiding this comment

home-assistant bot commented Sep 24, 2024

Bre77 commented Sep 24, 2024

Bre77 commented Sep 25, 2024

Bre77 left a comment

Choose a reason for hiding this comment

Bre77 commented Sep 25, 2024

JEMcats commented Sep 25, 2024

gjohansson-ST left a comment

Choose a reason for hiding this comment

JEMcats commented Sep 25, 2024 • edited Loading

gjohansson-ST Sep 25, 2024

Choose a reason for hiding this comment

Bre77 Sep 25, 2024

Choose a reason for hiding this comment

JEMcats Sep 25, 2024

Choose a reason for hiding this comment

gjohansson-ST Sep 25, 2024

Choose a reason for hiding this comment

JEMcats commented Sep 22, 2024 •

edited

Loading

JEMcats commented Sep 25, 2024 •

edited

Loading