Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tesla Fleet grid status #126438

Merged
merged 20 commits into from
Oct 7, 2024
Merged

Conversation

JEMcats
Copy link
Contributor

@JEMcats JEMcats commented Sep 22, 2024

Proposed change

This pull request adds 2 changes:

  • Grid Connected / Disconnected Status ('Unknown'/'Connected'/'Disconnected'/'Disconnected intentionally' )

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR is related to PR: #126003

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Updated Docs

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Bre77, mind taking a look at this pull request as it has been labeled with an integration (tesla_fleet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tesla_fleet can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tesla_fleet Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@JEMcats JEMcats changed the title Add Grid Status, And Storm Watch Active Status. Add Grid And Storm Watch Active Status. Sep 22, 2024
@JEMcats JEMcats mentioned this pull request Sep 22, 2024
19 tasks
Copy link
Contributor

@Bre77 Bre77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of small changes. Thanks!

homeassistant/components/tesla_fleet/sensor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Bre77 Bre77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry one last thing I missed, Added a suggestion you should just be able to commit.

homeassistant/components/tesla_fleet/sensor.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare changed the title Add Grid And Storm Watch Active Status. Add Tesla Fleet grid and storm watch active status Sep 22, 2024
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 24, 2024 07:35
@JEMcats JEMcats changed the title Add Tesla Fleet grid and storm watch active status Add Tesla Fleet grid status Sep 24, 2024
@JEMcats JEMcats marked this pull request as ready for review September 24, 2024 23:56
@Bre77
Copy link
Contributor

Bre77 commented Sep 24, 2024

@JEMcats run pytest ./tests/components/tesla_fleet --snapshot-update in your dev environment to update the test snapshots and commit the binary_sensory.ambr file it will update.

@Bre77
Copy link
Contributor

Bre77 commented Sep 25, 2024

You can use this as your documentation: home-assistant/home-assistant.io#34911

Copy link
Contributor

@Bre77 Bre77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generate testing snapshot and add documentation link to the PR description.

@Bre77
Copy link
Contributor

Bre77 commented Sep 25, 2024

@JEMcats sorry I made a bad assumption that your translations would be up to date. Delete the *.ambr files you generated, run script/setup then re-run the pytest command, this should generate some entries in sensors.ambr for the grid status entity only.

@JEMcats
Copy link
Contributor Author

JEMcats commented Sep 25, 2024

I completed those steps and there is nothing new to commit.

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the snapshot files, run compile translations and then regenerate the translation files so it gets up to date.

tests/components/tesla_fleet/snapshots/test_button.ambr Outdated Show resolved Hide resolved
tests/components/tesla_fleet/snapshots/test_lock.ambr Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 25, 2024 19:53
@JEMcats
Copy link
Contributor Author

JEMcats commented Sep 25, 2024

I compiled the translations and updated the *.ambr files. d8f61c0

@JEMcats JEMcats marked this pull request as ready for review September 25, 2024 20:03
@home-assistant home-assistant bot marked this pull request as draft September 25, 2024 20:05
@JEMcats JEMcats marked this pull request as ready for review October 5, 2024 11:58
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JEMcats 👍

@gjohansson-ST gjohansson-ST merged commit eac930a into home-assistant:dev Oct 7, 2024
27 checks passed
@JEMcats JEMcats deleted the tesla-status branch October 7, 2024 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants