Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Reolink Home Hub main level switches #126697

Merged
merged 8 commits into from
Sep 25, 2024

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Sep 24, 2024

Breaking change

The redundant "Record", "Email on event", "FTP upload", "Push notifications", and "Buzzer on event" switches on the Reolink Home Hub have been depricated since the new firmware no longer supports these.
Please use the equally named switches under each of the camera devices (connected to the Home Hub) instead to turn on/off recording.
This only applies to the Reolink Home Hub, not to Reolink NVRs.

Proposed change

The new Reolink Home Hub firmware will remove the ability to enable/disable recording, email, FTP, Push, and Buzzer on the Hub level (main switch).
Therefore clean-up this entity.

Enabeling/disabeling these switches on the camera level on the Home Hub will remain as is.

This has been done by Reolink because it was confusing to users that in order for recordings to be made on a camera both the main switch (Hub level) and the camera recording switch needed to be turned ON.

The main switch is redundant since when a user wants to disable all recordings, the user can just turn OFF all the recording switches (camera level) on each of the cameras (connected to the Home Hub).

Seperate version bump or Reolink-aio: #126778
Bump reolink-aio to 0.9.11:
Additions:

Bug fixes:

Full Changelog: starkillerOG/reolink_aio@0.9.10...0.9.11

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG changed the title Depricate Reolink Home Hub main level record switch Depricate Reolink Home Hub main level switches Sep 24, 2024
@edenhaus edenhaus changed the title Depricate Reolink Home Hub main level switches Deprecate Reolink Home Hub main level switches Sep 25, 2024
@edenhaus edenhaus added deprecation Indicates a breaking change to happen in the future breaking-change and removed bugfix deprecation Indicates a breaking change to happen in the future labels Sep 25, 2024
@edenhaus edenhaus changed the title Deprecate Reolink Home Hub main level switches Remove Reolink Home Hub main level switches Sep 25, 2024
@edenhaus
Copy link
Contributor

Starkiller looks if it's possible to deprecate with a repair issue instead of directly removing it

@edenhaus edenhaus marked this pull request as draft September 25, 2024 07:51
@starkillerOG starkillerOG marked this pull request as ready for review September 25, 2024 18:29
@starkillerOG
Copy link
Contributor Author

doing the Reolink-aio version bump now

@edenhaus edenhaus added deprecation Indicates a breaking change to happen in the future and removed breaking-change labels Sep 25, 2024
@edenhaus edenhaus removed this from the 2024.10.0b0 milestone Sep 25, 2024
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starkillerOG 👍

@edenhaus edenhaus merged commit 1395bae into home-assistant:dev Sep 25, 2024
30 checks passed
@starkillerOG starkillerOG deleted the reolink_depricate_rec branch September 25, 2024 19:56
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 25, 2024
Co-authored-by: Robert Resch <robert@resch.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by-code-owner cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: reolink Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants