Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update denonavr to v1.0.0 #126703

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Update denonavr to v1.0.0 #126703

merged 3 commits into from
Sep 25, 2024

Conversation

ol-iver
Copy link
Contributor

@ol-iver ol-iver commented Sep 24, 2024

Proposed change

This PR updates denonavr library to v1.0.0 (changelog).

Additionally, it removes an duplicate query to the receiver during async_setup_entry. It is not required, because the receiver entities are added with update_before_add=True which performs the same query too.
The removed query could also cause uncaught exceptions, e.g. on timeouts.

Finally, all configured zones are updated before telnet is connected, because the telnet connection affects all zones.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (denonavr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of denonavr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign denonavr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with Marantz NR1711 👍

Thanks @ol-iver

@bdraco bdraco added this to the 2024.10.0b0 milestone Sep 24, 2024
We set `update_before_add=True` anyway which also performs the query.
Additionally, the removed call could cause an uncaught exception, e.g. on timeouts.
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Sep 25, 2024
@frenck
Copy link
Member

frenck commented Sep 25, 2024

CI error isn't related, I'll go ahead with the merge.

@frenck frenck merged commit 1c33561 into home-assistant:dev Sep 25, 2024
40 of 41 checks passed
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed dependency integration: denonavr Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
4 participants