Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license check for new aiocache #126753

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix license check for new aiocache #126753

merged 1 commit into from
Sep 25, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 25, 2024

Proposed change

This one is still a todo but a new version was just released

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

This one is still a todo but a new version was just released
@bdraco bdraco requested a review from a team as a code owner September 25, 2024 13:29
@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Sep 25, 2024
@bdraco bdraco mentioned this pull request Sep 25, 2024
24 tasks
@bdraco bdraco added the bugfix label Sep 25, 2024
@bdraco bdraco merged commit f4c339d into dev Sep 25, 2024
45 checks passed
@bdraco bdraco deleted the fix_license_check_aiocache branch September 25, 2024 14:00
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Sep 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants