Add Bang & Olufsen device triggers #126755
Conversation
Add initial testing
Reorder triggers
Update parameter naming
|
Please fix the merge conflicts |
| def on_beo_remote_button_notification(self, notification: BeoRemoteButton) -> None: | ||
| """Send beo_remote_button dispatch.""" | ||
| # Trigger the device trigger | ||
| self.hass.bus.async_fire( | ||
| BANG_OLUFSEN_EVENT, | ||
| event_data={ | ||
| CONF_TYPE: f"{notification.key}_{notification.type}", | ||
| CONF_DEVICE_ID: self._device.id, | ||
| }, | ||
| ) | ||
|
|
||
| def on_button_notification(self, notification: ButtonEvent) -> None: | ||
| """Send button dispatch.""" | ||
| # Trigger the device trigger | ||
| self.hass.bus.async_fire( | ||
| BANG_OLUFSEN_EVENT, | ||
| event_data={ | ||
| CONF_TYPE: f"{notification.button}_{notification.state}", | ||
| CONF_DEVICE_ID: self._device.id, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
I'd suggest to, in an initial PR, add event entities, where each button is one event entity which can fire different events.
I'm not sure if device triggers are needed as well, maybe not?
Also, should the beo remotes be their own devices?
There was a problem hiding this comment.
I guess I could add the Beoremote One as a device, I'll take a look at that. I didn't even know event Entities were a thing, so I'll take a look at that as well. I'll convert this PR to a draft for now.
There was a problem hiding this comment.
OK, I've pushed an initial commit containing event entities for the physical buttons as well as Beoremote One keys and a device for the Beoremote One. There are 10 Event entities for the physical buttons and 58 for Beoremote One keys. This seems to be a bit excessive, but still seems to be a better way to handle events. What are your thoughts?
| "device_automation": { | ||
| "trigger_type": { |
There was a problem hiding this comment.
If you decide to still support device triggers, I'd suggest to have one type for each kind of keypress, and a subtype for each button. That should avoid overwhelming the user with a huge list of triggers.
Example:
core/homeassistant/components/hue/strings.json
Lines 43 to 75 in 43642a8
Proposed change
Add device triggers for the physical "button" events that make sense and all triggers from the Beoremote One.
Most of the physical buttons have their own actions and do therefore not make sense to have device triggers for.
The Beoremote One has two menus that are available as device triggers:
LightandControl.These menus can be entered to trigger user renamable functions, for example:
Control -> Window 1which will trigger theControl/Func1_KeyPressandControl/Func1_KeyReleasedevice triggers. By pressingSelecton the menus, the user can press most of the buttons on the remote likeControl/Digit9_KeyRelease,Control/Blue_KeyPress,Control/Wind_KeyReleaseetc.The device triggers for the remote will only be exposed to the use if a Beoremote One is connected to the device.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: