Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiorussound to 4.0.5 #126774

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

noahhusby
Copy link
Contributor

@noahhusby noahhusby commented Sep 25, 2024

Proposed change

⚠️ Please include this in 2024.10 beta

The API contains a few model changes which impact a bunch of the implementation on the integration side.

Changelog: noahhusby/aiorussound@3.1.5...4.0.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@noahhusby
Copy link
Contributor Author

CI failure unrelated to changes

@noahhusby noahhusby changed the title Bump aiorussound to 4.0.4 Bump aiorussound to 4.0.5 Sep 25, 2024
@joostlek joostlek added this to the 2024.10.0 milestone Sep 26, 2024
@home-assistant home-assistant bot marked this pull request as draft September 26, 2024 08:55
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@noahhusby noahhusby marked this pull request as ready for review September 26, 2024 12:06
@joostlek joostlek merged commit 7afad1d into home-assistant:dev Sep 26, 2024
43 of 44 checks passed
@noahhusby noahhusby deleted the feat/bump-aiorussound-4.0.0 branch September 26, 2024 14:47
frenck pushed a commit that referenced this pull request Sep 26, 2024
* Bump aiorussound to 4.0.4

* Remove unnecessary exception

* Bump aiorussound to 4.0.5

* Fixes

* Update homeassistant/components/russound_rio/media_player.py

---------

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Russound_Rio reconnect after power cycle amp
3 participants