Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hass httpx client for ElevenLabs component #126793

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

sorgfresser
Copy link
Contributor

Proposed change

Use the Httpx Client by Hass instead of the default one of the elevenlabs python sdk to stop blocking HomeAssistant's event loop.

I am not quite sure whether I can really test this behaviour in pytest, but the tests cover that at least no major issue is introduced and I verified locally that this resolves the warnings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sorgfresser 👍

../Frenck

@frenck frenck added this to the 2024.10.0 milestone Sep 27, 2024
@frenck frenck merged commit 616c0eb into home-assistant:dev Sep 27, 2024
31 checks passed
@sorgfresser sorgfresser deleted the elevenlabs-httpx-client branch September 27, 2024 22:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cherry-picked cla-signed integration: elevenlabs Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elevenlabs - Detected blocking call to load_verify_locations with args
2 participants