-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to Configure Scan Interval to vesync #127152
Conversation
Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This code currently shows the option in the GUI. I am not clear how to assign it to the entity. I haven't done it before without a coordinator. More research needed but if someone could point me to an example that would be awesome. I need to essentially set scan_interval = self._config_entry.options[CONF_SCAN_INTERVAL] however the config entry isn't available in the entity. |
vol.Optional( | ||
CONF_SCAN_INTERVAL, | ||
default=self.config_entry.options.get( | ||
CONF_SCAN_INTERVAL, DEFAULT_SCAN_INTERVAL | ||
), | ||
): int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not allow configuration of the scan interval.
We should provide a sane default out of the box. In case the default isn't correct, we should adjust that.
If an user wants to use a different schedule or a conditional scan interval, they can use the homeassistant.update_entity service instead.
Proposed change
Adds a scan_interval setting to resolve rate limiting on the API as per this issue:
#122620
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: