Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary sensor platform to eq3btsmart #130352

Merged

Conversation

EuleMitKeule
Copy link
Contributor

@EuleMitKeule EuleMitKeule commented Nov 11, 2024

Proposed change

This PR adds binary sensor entities to the eq3btsmart integration, which allow the user to gain more insight about the state of their eQ-3 Bluetooth Smart Thermostat devices.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dbuezas, mind taking a look at this pull request as it has been labeled with an integration (eq3btsmart) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of eq3btsmart can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign eq3btsmart Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@EuleMitKeule
Copy link
Contributor Author

#130263 (comment)

This requested change leads to mypy failing with no-any-return, that's why it's not included.

homeassistant/components/eq3btsmart/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/eq3btsmart/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/eq3btsmart/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/eq3btsmart/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/eq3btsmart/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/eq3btsmart/strings.json Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 11, 2024 11:55
@EuleMitKeule EuleMitKeule marked this pull request as ready for review November 11, 2024 12:08
@joostlek joostlek merged commit 829632b into home-assistant:dev Nov 11, 2024
33 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants