-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit translations for github integration #130538
Conversation
We should extend the scope of this PR to not only add unit tests but also implementation changes |
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Normally when implementing changes from arch discussions those PRs only introduce the changes/features needed in the entity components and not in integrations that might use it. Are we doing something different here and there is no frontend PR (yet)? |
There are no other changes on the entity components for this. I've kept only the changes on the youtube integration to make this simpler, though.
Yes, there is work needed on the frontend too. |
…s_translation_tests
Switched to the github integration since I can test it out with the frontend. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @abmantis 👍
../Frenck
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Breaking change
The units of measurement of the following sensors for the github integration were changed to lowercase:
Proposed change
This adds
native_unit_of_measurement
translation to github integrations, as a basis implementation for home-assistant/architecture#1056Needs home-assistant/frontend#22868
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: