Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify recorder RecorderRunsManager #131785

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Simplify recorder RecorderRunsManager #131785

merged 2 commits into from
Dec 1, 2024

Conversation

emontnemery
Copy link
Contributor

Proposed change

Simplify recorder RecorderRunsManager

With merge of PR #131702, we no longer need to keep all the rows in the RecorderRuns table in memory

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner November 28, 2024 07:19
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

emontnemery
emontnemery commented Nov 28, 2024
View reviewed changes
homeassistant/components/recorder/table_managers/recorder_runs.py
Comment on lines 28 to +31
@property
def first(self) -> RecorderRuns:
"""Get the first run."""
if runs_by_timestamp := self._run_history.runs_by_timestamp:
return next(iter(runs_by_timestamp.values()))
return self.current
return self._first_run or self.current
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first property is used for system health. Considering we're no longer relying on the recorder runs to avoid unnecessary history queries, but instead the timestamp of the oldest state, we should perhaps remove this property and include the timestamp of the oldest state in the system health information instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good change to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll do that in a follow-up 👍

@bdraco bdraco merged commit cf0ee63 into dev Dec 1, 2024
64 checks passed
@bdraco bdraco deleted the recorder_simplify_recorder_runs branch December 1, 2024 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@emontnemery emontnemery added this to the 2024.12.4 milestone Dec 14, 2024
@emontnemery
Copy link
Contributor Author

Tagged for 2024.12.4 to avoid merge conflicts when including revert of PR #131702 in the milestone

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed code-quality core has-tests integration: recorder Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.12.4
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @bdraco @frenck