Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API change for AC not supporting floats in SwitchBot Cloud #132231

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

SeraphicRav
Copy link
Contributor

@SeraphicRav SeraphicRav commented Dec 4, 2024

Breaking change

Proposed change

Fixing non supported decimals in AC settings

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Hey there @laurence-presland, @Gigatrappeur, mind taking a look at this pull request as it has been labeled with an integration (switchbot_cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot_cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot_cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@SeraphicRav SeraphicRav closed this Dec 4, 2024
@SeraphicRav SeraphicRav deleted the Switchbot130516 branch December 4, 2024 04:55
@SeraphicRav SeraphicRav restored the Switchbot130516 branch December 4, 2024 04:56
@SeraphicRav
Copy link
Contributor Author

Here was actually the correct branch

@SeraphicRav SeraphicRav reopened this Dec 4, 2024
@SeraphicRav SeraphicRav marked this pull request as ready for review December 4, 2024 06:47
@SeraphicRav SeraphicRav changed the title Switchbot Cloud: Fixng API change for AC not supporting floats Switchbot Cloud: BugFix API change for AC not supporting floats Dec 4, 2024
@SeraphicRav SeraphicRav changed the title Switchbot Cloud: BugFix API change for AC not supporting floats Fix API change for AC not supporting floats in SwitchBot Cloud Dec 4, 2024
@MrXANA91
Copy link
Contributor

MrXANA91 commented Dec 5, 2024

Similar change fixed issue #130516 in an external HACS integration : KiraPC/ha-switchbot-remote#58

@joostlek joostlek added this to the 2024.12.2 milestone Dec 8, 2024
@joostlek joostlek added the bugfix label Dec 8, 2024
@joostlek joostlek merged commit ce8c5fc into home-assistant:dev Dec 8, 2024
34 checks passed
@SeraphicRav SeraphicRav deleted the Switchbot130516 branch December 9, 2024 00:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switchbot cloud IR for airconditioners
4 participants