-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API change for AC not supporting floats in SwitchBot Cloud #132231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
integration: switchbot_cloud
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Dec 4, 2024
Hey there @laurence-presland, @Gigatrappeur, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Here was actually the correct branch |
SeraphicRav
force-pushed
the
Switchbot130516
branch
from
December 4, 2024 06:47
2f59e4f
to
b520095
Compare
SeraphicRav
changed the title
Switchbot Cloud: Fixng API change for AC not supporting floats
Switchbot Cloud: BugFix API change for AC not supporting floats
Dec 4, 2024
SeraphicRav
changed the title
Switchbot Cloud: BugFix API change for AC not supporting floats
Fix API change for AC not supporting floats in SwitchBot Cloud
Dec 4, 2024
19 tasks
Similar change fixed issue #130516 in an external HACS integration : KiraPC/ha-switchbot-remote#58 |
joostlek
approved these changes
Dec 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
integration: switchbot_cloud
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fixing non supported decimals in AC settings
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: