Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass an application identifier to the Hydrawise API #132779

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

dknowles2
Copy link
Contributor

Proposed change

This provides a new field (app_id) to the Hydrawise API for identifying Home Assistant and its current version.

This is meant to help remediate throttling errors, which occur when there is no app_id specified. Providing the specific HA version performing the request should also allow Hydrawise to throttle specific HA versions, if needed.

Note that this requires pydrawise 2024.12.0 (bumped in #132015)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @thomaskistler, @ptcryan, mind taking a look at this pull request as it has been labeled with an integration (hydrawise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hydrawise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hydrawise Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dknowles2 dknowles2 changed the title Pass an app_id to the Hydrawise API Pass an application identifier to the Hydrawise API Dec 10, 2024
frenck
frenck previously requested changes Dec 10, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @dknowles2 👋

There seems to be a merge conflict, could you take a look?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 10, 2024 07:41
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dknowles2
Copy link
Contributor Author

Hi there @dknowles2 👋

There seems to be a merge conflict, could you take a look?

Thanks! 👍

../Frenck

Resolved! 😄

@dknowles2 dknowles2 marked this pull request as ready for review December 10, 2024 12:45
@home-assistant home-assistant bot requested a review from frenck December 10, 2024 12:45
@joostlek joostlek added this to the 2024.12.2 milestone Dec 10, 2024
@joostlek joostlek dismissed frenck’s stale review December 10, 2024 12:50

Merge conflict solved

@edenhaus edenhaus merged commit 9614a8d into home-assistant:dev Dec 10, 2024
34 checks passed
@frenck frenck mentioned this pull request Dec 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydrawise still giving error 429 - too many poll requests
4 participants