Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AndroidTV logging when disconnected #132919

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix AndroidTV logging when disconnected #132919

merged 2 commits into from
Dec 12, 2024

Conversation

chemelli74
Copy link
Contributor

Breaking change

Proposed change

Change logging level to avoid filling up the log while the device is off:

2024-12-11 12:18:04.767 WARNING (MainThread) [androidtv.adb_manager.adb_manager_async] Couldn't connect to 192.168.1.84:5555.  TcpTimeoutException: Connecting to 192.168.1.84:5555 timed out (1.0 seconds)
2024-12-11 12:19:26.024 WARNING (MainThread) [androidtv.adb_manager.adb_manager_async] Couldn't connect to 192.168.1.84:5555.  TcpTimeoutException: Connecting to 192.168.1.84:5555 timed out (1.0 seconds)
2024-12-11 12:20:47.162 WARNING (MainThread) [androidtv.adb_manager.adb_manager_async] Couldn't connect to 192.168.1.84:5555.  TcpTimeoutException: Connecting to 192.168.1.84:5555 timed out (1.0 seconds)
2024-12-11 12:22:08.523 WARNING (MainThread) [androidtv.adb_manager.adb_manager_async] Couldn't connect to 192.168.1.84:5555.  TcpTimeoutException: Connecting to 192.168.1.84:5555 timed out (1.0 seconds)
2024-12-11 12:23:30.003 WARNING (MainThread) [androidtv.adb_manager.adb_manager_async] Couldn't connect to 192.168.1.84:5555.  TcpTimeoutException: Connecting to 192.168.1.84:5555 timed out (1.0 seconds)
2024-12-11 12:24:51.397 WARNING (MainThread) [androidtv.adb_manager.adb_manager_async] Couldn't connect to 192.168.1.84:5555.  TcpTimeoutException: Connecting to 192.168.1.84:5555 timed out (1.0 seconds)
2024-12-11 12:26:12.708 WARNING (MainThread) [androidtv.adb_manager.adb_manager_async] Couldn't connect to 192.168.1.84:5555.  TcpTimeoutException: Connecting to 192.168.1.84:5555 timed out (1.0 seconds)
2024-12-11 12:27:33.878 WARNING (MainThread) [androidtv.adb_manager.adb_manager_async] Couldn't connect to 192.168.1.84:5555.  TcpTimeoutException: Connecting to 192.168.1.84:5555 timed out (1.0 seconds)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@chemelli74 chemelli74 added this to the 2024.12.3 milestone Dec 11, 2024
@home-assistant
Copy link

Hey there @JeffLIrion, @ollo69, mind taking a look at this pull request as it has been labeled with an integration (androidtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of androidtv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign androidtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

zweckj
zweckj reviewed Dec 11, 2024
View reviewed changes
homeassistant/components/androidtv/__init__.py Outdated
Comment on lines 148 to 149
DEFAULT_TRANSPORT_TIMEOUT_S,
False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just?

Suggested change
DEFAULT_TRANSPORT_TIMEOUT_S,
False,
log_errors=False,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have added the param name for all of them, but I just aligned to the syntax used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally I'd say just add it to all of them and leave out the default

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho providing param name and avoid to import useless constant is better.
But be careful, in this way we will totally loose information about what is causing connection failure.
My suggestion is to find a way to set this value to false only if this is not the first try, so error will be logged at least once.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though the approach would be to add as less changes as possible, but I agree on the approach.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So let's leave for a next PR, but don't forget this. Connection error log should be useful in many cases.

@frenck frenck marked this pull request as draft December 11, 2024 17:57
@chemelli74 chemelli74 marked this pull request as ready for review December 11, 2024 20:24
zweckj
zweckj approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edenhaus edenhaus merged commit ded7cee into home-assistant:dev Dec 12, 2024
34 checks passed
@chemelli74 chemelli74 deleted the chemelli74-android-tv-logging branch December 12, 2024 12:13
frenck pushed a commit that referenced this pull request Dec 13, 2024
@chemelli74 @frenck
fix AndroidTV logging when disconnected (#132919)
ede9c3e
@frenck frenck mentioned this pull request Dec 13, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ollo69 ollo69 ollo69 left review comments

@zweckj zweckj zweckj approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed integration: androidtv Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.12.3
Development

Successfully merging this pull request may close these issues.
5 participants
@chemelli74 @zweckj @ollo69 @frenck @edenhaus